-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jan Engelhardt wrote:
> On Sep 14 2007 16:35, Yan Zheng wrote:
>>> 10:15 ichi:../include/linux > grep remove_suid *
>>> fs.h:extern int __remove_suid(struct path *, int);
>>> fs.h:extern int should_remove_suid(struct dentry *);
>>> fs.h:extern int remove_suid(struct path *);
>>> This may be due to the apparmor stuff.
>> Strange enough, I found the declaration of remove_suid is 'extern int
>> remove_suid(struct dentry *);' in both 2.6.22 and 2.6.23-rc5.
> 
> Yes, like I said this must be the apparmor patch Novell puts in :-/

I posted a patch for the btrfs packages on the opensuse build service
that tweaks this to work with AppArmor. I've attached it.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFG6lYHLPWxlyuTD7IRAiG7AJ0Z1T5AUmjMislrX9cWZ2/QAKi74gCgqMrE
jjqm509dUc2My3QZjpiU1C8=
=f4Y/
-----END PGP SIGNATURE-----
diff -rup a/source/file.c b/source/file.c
--- a/file.c	2007-06-12 11:36:58.000000000 -0400
+++ b/file.c	2007-06-12 14:06:53.000000000 -0400
@@ -482,7 +482,7 @@ static ssize_t btrfs_file_write(struct f
 		goto out;
 	if (count == 0)
 		goto out;
-	err = remove_suid(file->f_path.dentry);
+	err = remove_suid(&file->f_path);
 	if (err)
 		goto out;
 	file_update_time(file);
_______________________________________________
Btrfs-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/btrfs-devel

Reply via email to