Dear Chris,
File / Open brings up a list of functions I can edit. I select the
function and click OK. The system segfaults and exits immediately upon
clicking the OK button.
Interestingly, I noticed that it allows editing of some functions but not
others. It is very consistent, so it is something in the function.
For example, I've found that this function (in a WS by itself) cannot be
edited:
∇Change[⎕]∇
∇
[0] Change;L;s;q
[1] →(0=1↑⍴Mat)/ER1
[2] EN1:→(EHN L←(1 ¯1,⍳1↑⍴Mat)Piv'Enter the line numbers you wish to
change')/0,EN1,0
[3] LP1:→(0=⍴L)/END
[4] q←Edit Mat[''⍴L;]
[5] →((1↓⍴Mat)=s←(⍴q)⌈1↓⍴Mat)/EN2
[6] Mat←((1↑⍴Mat),s)↑Mat
[7] EN2:Mat[1↑L;]←s↑q
[8] L←1↓L
[9] →LP1
[10] END:Mat←RS Mat
[11] →0
[12] ER1: ER'There are no lines to change.'
∇
I am finding other anomalies too. I'll report those separately.
Thanks.
Blake
On Fri, Sep 12, 2014 at 3:42 PM, Chris Moller <[email protected]> wrote:
> I was just about to ask about that. Since I can't reproduce the bug,
> about all I can do is eyeball they code and look for potential problems.
> Since it appears to involve g_utf8_validate, there are only a couple of
> possibilities.
>
> If I understood your note from this morning, the select menu comes up, you
> select something, and then get the Gtk-CRITICAL? Does the edit window come
> up? Does Open/New work?
>
> Thanks,
> cm
>
>
> On 09/12/14 16:33, Blake McBride wrote:
>
> File / Open still doesn't work, but the other stuff is working great now.
> Thanks to you and David!
>
> Blake
>
> On Fri, Sep 12, 2014 at 3:09 PM, Chris Moller <[email protected]>
> wrote:
>
>> Cool. Applied and pushed.
>>
>> Blake, when you get a chance, can you try it out?
>>
>> cm
>>
>> On 09/12/14 15:54, David B. Lamkins wrote:
>>
>> Chris,
>>
>> The attached patch cleans up key handling:
>>
>> 1. For reasons of clarity and maintainability, I've factored out most of
>> the inline handlers from key_press_event().
>>
>> 2. In maybe_copy_selected_text_without_tags(), I added a missing call to
>> g_free().
>>
>> 3. In key_press_event(), I'm now using the result of
>> gtk_accelerator_get_default_mod_mask() to mask out lock keys where
>> needed.
>>
>> 4. I fixed an additional issue related to the presence of an uppercase
>> key value in Ctrl-C and Ctrl-X detection for the copy/paste fix reported
>> by Blake.
>>
>>
>>
>
>
