There's one remaining when compiling 843 under clang. The attached patch fixes
that as well as the remaining error reported by gcc.
On Tue, Jan 10, 2017 at 03:54:36PM -0800, David Lamkins wrote:
> Worth noting: There are now no warnings or notes when compiling under gcc
> 6.3.1.
>
> On Tue, Jan 10, 2017 at 3:45 PM, David Lamkins <[email protected]> wrote:
> > Thank you, Juergen.
> >
> > SVN 843 compiles under gcc 6.3.1.
> >
> > This is the sole remaining error when compiling with clang 3.8.0:
> >
> > clang++ -DHAVE_CONFIG_H -I. -I.. -Werror -Wall -Wno-strict-aliasing
> > -Wno-deprecated-declarations -I/usr/include -I sql -I/usr/include -I
> > sql -g -O2 -MT apl-UserFunction_header.o -MD -MP -MF
> > .deps/apl-UserFunction_header.Tpo -c
> > -o apl-UserFunction_header.o `test -f 'UserFunction_header.cc' ||
> > echo './'`UserFunction_header.cc
> > Tokenizer.cc:604:42: error: explicitly assigning value of variable of
> > type 'APL_Float' (aka 'double') to itself [-Werror,-Wself-assign]
> > if (!imag_need_float) imag_flt = imag_flt;
> > ~~~~~~~~ ^ ~~~~~~~~
> > Tokenizer.cc:637:45: error: explicitly assigning value of variable of
> > type 'APL_Float' (aka 'double') to itself [-Werror,-Wself-assign]
> > if (!imag_need_float) degrees_flt = degrees_flt;
> > ~~~~~~~~~~~ ^ ~~~~~~~~~~~
> > 2 errors generated.
> >
> >
> > On Tue, Jan 10, 2017 at 11:54 AM, Juergen Sauermann
> > <[email protected]> wrote:
> >> Hi,
> >>
> >> I believe that I fixed most warnings, *SVN 842*.
> >>
> >> Since there were many warnings and from different sources, I might have
> >> overlooked
> >> some of them (or introduced new ones). Please keep reporting them.
> >>
> >> /// Jürgen
> >>
> >
> >
> >
> > --
> > "I think as musicians, we have more vision than we credit ourselves
> > for. We should dive into it without reserve, and take the sort of
> > risks it takes to be divisive and impactful. Things have yet to be
> > done."
> > Aaron Fowler Clark
> >
> > "Do not seek to follow in the footsteps of the masters. Seek what they
> > sought."
> > Matsuo Basho
> >
> > "Knowledge speaks; wisdom listens."
> > Jimi Hendrix
> >
> > http://soundcloud.com/davidlamkins
> > http://reverbnation.com/lamkins
> > http://reverbnation.com/lcw
> > http://lamkins-guitar.com/
> > http://lamkins.net/
> > http://successful-lisp.com/
>
>
>
> --
> "I think as musicians, we have more vision than we credit ourselves
> for. We should dive into it without reserve, and take the sort of
> risks it takes to be divisive and impactful. Things have yet to be
> done."
> Aaron Fowler Clark
>
> "Do not seek to follow in the footsteps of the masters. Seek what they
> sought."
> Matsuo Basho
>
> "Knowledge speaks; wisdom listens."
> Jimi Hendrix
>
> http://soundcloud.com/davidlamkins
> http://reverbnation.com/lamkins
> http://reverbnation.com/lcw
> http://lamkins-guitar.com/
> http://lamkins.net/
> http://successful-lisp.com/
Index: src/APs/AP210.cc
===================================================================
--- src/APs/AP210.cc (revision 843)
+++ src/APs/AP210.cc (working copy)
@@ -201,7 +201,7 @@
delete var_D.data;
var_D.data = new CDR_string(buffer, nb);
- delete buffer;
+ delete[] buffer;
return 0;
}
else if (code == 'D') // char (var size)
Index: src/Tokenizer.cc
===================================================================
--- src/Tokenizer.cc (revision 843)
+++ src/Tokenizer.cc (working copy)
@@ -601,7 +601,7 @@
bool imag_need_float = false;
const bool imag_valid = tokenize_real(src, imag_need_float,
imag_flt, imag_int);
- if (!imag_need_float) imag_flt = imag_flt;
+ if (!imag_need_float) (void)imag_flt;
if (!imag_valid)
{
@@ -634,7 +634,7 @@
bool imag_need_float = false;
const bool imag_valid = tokenize_real(src, imag_need_float,
degrees_flt, degrees_int);
- if (!imag_need_float) degrees_flt = degrees_flt;
+ if (!imag_need_float) (void)degrees_flt;
if (!imag_valid)
{
