Hello Dagobert,

[ quoting your message slightly out of order ]

* Dagobert Michelsen wrote on Mon, May 18, 2009 at 06:16:15PM CEST:
> I have 15 failed tests for automake 1.11 on Solaris 10 x86 with the
> Sun Studio compiler:

> Please see the detailed log at
>   <http://buildfarm.opencsw.org/automake/test-suite.log>

Thank you for the report, and for making the log file available.

> I guess these errors can not be safely ignored?

I'm not quite sure yet.

> XFAIL: all.test
> XFAIL: auxdir2.test
> XFAIL: cond17.test
> XFAIL: txinfo5.test

These are eXpected FAILures and can safely be ignored.

> FAIL: insthook.test

The insthook.test failure looks like you have some variables like
$bindir or $exec_prefix or $prefix set in your environment.  Is that
the case?  Maybe you can look over your environment for other possibly
problematic settings.  We should clear them in tests/defs, I guess.

> FAIL: man3.test

This fails for similar reasons, suggesting that you have $prefix set.

> FAIL: vala4.test

This is a genuine bug in one of Automake, Autoconf, or your system shell
(which we'd then need to work around).  I'm seeing it on a Solaris
system myself; will analyze.

> FAIL: depcomp7.test
> FAIL: instdir-ltlib.test
> FAIL: instfail-libtool.test
> FAIL: libtool5.test
> FAIL: libtool6.test
> FAIL: libtool8.test
> FAIL: libtoo10.test
> FAIL: libtoo11.test
> FAIL: ltinstloc.test
> FAIL: ltorder.test
> FAIL: pr211.test
> FAIL: silent3.test

These all end with something like this, a successful command and
supposedly an error in the cleanup trap:

| + : 
| exit_status=0
| + cd
| 
/export/home/dam/mgar/pkg/automake/trunk/work/build-isa-i386/automake-1.11/tests
 
| + chmod -R a+rwx libtoo11.dir 

Now, I bet the chmod throws an error, but since the code in
tests/defs.in diverts stdout and stderr to /dev/null, we don't get to
see it.  Can you do two tests for me, in order to analyze this issue?

Please apply the first patch attached to this message, then run
  make
  cd tests
  make recheck

and post the detailed log of that, so we can find out why the chmod
fails?  (If you don't have the build tree any more, then you can run
'make check' instead of 'make recheck', but it will take longer unless
you limit the tests as described in tests/README.)

Then, after that, please revert the first patch, and instead apply the
second attached patch, then run
  make
  cd tests
  make recheck

to verify that most of the failures are gone now?

(If both steps were combined, the test-suite.log would not contain the
error message from the chmod any more, if the tests do not fail any
more.)

If my hypothesis is true, I will then apply the second patch to
Automake, and add you to THANKS if you don't mind.

Cheers,
Ralf
diff --git a/tests/defs.in b/tests/defs.in
index 6e26202..b3c4607 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -257,7 +257,7 @@ if test "$sh_errexit_works" = yes; then
     cd "$curdir"
     case $exit_status,$keep_testdirs in
     0,)
-      chmod -R a+rwx $testSubDir > /dev/null 2>&1
+      chmod -R a+rwx $testSubDir
       rm -rf "$testSubDir" ;;
     esac
     test "$signal" != 0 &&
diff --git a/tests/defs.in b/tests/defs.in
index 6e26202..7d74dd2 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -254,6 +254,7 @@ mkdir $testSubDir
 sh_errexit_wor...@sh_errexit_works@
 if test "$sh_errexit_works" = yes; then
   trap 'exit_status=$?
+    set +e
     cd "$curdir"
     case $exit_status,$keep_testdirs in
     0,)

Reply via email to