Re: mv: cannot stat `test-suite.log': Permission denied

[Ralf Wildenhues]

Hi Bob,

thanks for the report.

* Bob Friesenhahn wrote on Fri, Sep 11, 2009 at 10:57:29PM CEST:
> Under MinGW, I have now encountered this error at the end of 'make
> check' when using parallel tests and color tests:
> 
>   mv: cannot stat `test-suite.log': Permission denied
> 
> and this file was left as a result:
> 
>   test-suite.log.tmp
> 
> This was for a non-parallel 'make check'.

Is this deterministic?  How can I reproduce it?  On what file system?
Does the patch below prevent it from happening?

For faster test cycles, you can try 'make check TESTS=onlyoneofthem'.

Thanks,
Ralf

diff --git a/lib/am/check.am b/lib/am/check.am
index b1d1aad..1a7f191 100644
--- a/lib/am/check.am
+++ b/lib/am/check.am
@@ -201,7 +201,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
            esac;                                                       \
          done;                                                         \
        } >$(TEST_SUITE_LOG).tmp;                                       \
-       mv $(TEST_SUITE_LOG).tmp $(TEST_SUITE_LOG);                     \
+       mv -f $(TEST_SUITE_LOG).tmp $(TEST_SUITE_LOG);                  \
        if test "$$failures" -ne 0; then                                \
          msg="$${msg}See $(subdir)/$(TEST_SUITE_LOG).  ";              \
          if test -n "$(PACKAGE_BUGREPORT)"; then                       \
@@ -258,7 +258,7 @@ AM_RECURSIVE_TARGETS += check
          exit 2;                                                       \
        fi;                                                             \
        $$R2H $< >$...@.tmp
-       @mv $...@.tmp $@
+       @mv -f $...@.tmp $@
 
 # Be sure to run check first, and then to convert the result.
 # Beware of concurrent executions.  Run "check" not "check-TESTS", as