Hi Bruno, thanks for the report.
On 03/26/2012 02:06 AM, Bruno Haible wrote:
>> Testing with Cygwin, MSYS/MinGW, MacOS X, and proprietary UNIX systems
>> (e.g., AIX, IRIX, older Solaris) would be greatly appreciated.
>
> On MacOS X 10.5: All tests passed.
>
Good! :-)
> On Linux (openSUSE 12.1):
>
> FAIL: conffile-leading-dot.test
>
This is likely due to some know racy spurious failures already fixed on master
but (for some reasons) not on maint. The attached "backporting" patches should
take care of the issue. Can you confirm they works?
> FAIL: vala-vpath.test
> FAIL: vala-mix.test
> FAIL: vala-mix2.test
> [SNIP]
> rm -f ../foo_vala.stamp && echo stamp > ../foo_vala.stamp-t
> CDPATH="${ZSH_VERSION+.}:" && cd .. && /arch/x86_64-linux/gnu/bin/valac
> --profile=posix -C hello.vala
> Unknown option --profile=posix
> Run '/arch/x86_64-linux/gnu/bin/valac --help' to see a full list of available
> command line options.
> make: *** [../foo_vala.stamp] Error 1
> + exit_status=2
> + set +e
> + cd
> /data/home-susekde4/bruno/data/build/multibuild-1986/linux/automake-1.11.3b/tests
> + case $exit_status,$keep_testdirs in
> + test 0 '!=' 0
> + echo 'vala-vpath: exit 2'
> vala-vpath: exit 2
> + exit 2
>
> The reason is that the 'valac' program that I have in my $PATH is version
> 0.7, and it does not support the --profile option:
>
> $ valac --version
> Vala 0.7.2
>
> Looking at git://git.gnome.org/vala it is clear that the option --profile
> was added on 2009-05-08, in version 0.7.3. The autoconf test reported
> "checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7... yes"
> which is correct. But it should have tested for at least version 0.7.3.
>
Thanks for the analysis. I've added you as the main author of the patch to
fix this bug (attached). Can you confirm that it works, and give your ACK
to the authorship attribution?
Thanks,
Stefano
>From e8d53803885616b705b0b65bdb66da12fa818fd2 Mon Sep 17 00:00:00 2001
Message-Id: <e8d53803885616b705b0b65bdb66da12fa818fd2.1332764878.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <[email protected]>
Date: Thu, 16 Feb 2012 10:58:03 +0100
Subject: [PATCH 1/2] tests: fix spurious failure with older autoconf
Cherry picked from commit v1.11-1950-gba5a89b of 16-02-2012.
* tests/conffile-leading-dot.test: Relax grepping of 'config.status'
stderr, to cater for older autoconf. Issue revealed by a failure
with autoconf 2.63 on Cygwin 1.5.25. See also automake bug#11093.
Signed-off-by: Stefano Lattarini <[email protected]>
---
tests/conffile-leading-dot.test | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/conffile-leading-dot.test b/tests/conffile-leading-dot.test
index 1d3d12f..1ee153f 100755
--- a/tests/conffile-leading-dot.test
+++ b/tests/conffile-leading-dot.test
@@ -57,6 +57,6 @@ echo foo = bazbazbaz > Makefile.am
# giving a bogus warning.
$MAKE 2>stderr && { cat stderr >&2 Exit 1; }
cat stderr >&2
-grep "config\\.status:.*invalid argument.*[\`\"']Makefile[\`\"']" stderr
+grep "config\\.status:.*invalid argument.*Makefile" stderr
:
--
1.7.9
>From d6f2cc911bad4d1d4457aee63f7c8c6d0b754a36 Mon Sep 17 00:00:00 2001
Message-Id: <d6f2cc911bad4d1d4457aee63f7c8c6d0b754a36.1332764878.git.stefano.lattar...@gmail.com>
In-Reply-To: <e8d53803885616b705b0b65bdb66da12fa818fd2.1332764878.git.stefano.lattar...@gmail.com>
References: <e8d53803885616b705b0b65bdb66da12fa818fd2.1332764878.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <[email protected]>
Date: Mon, 20 Feb 2012 14:04:46 +0100
Subject: [PATCH 2/2] tests: fix a timestamp issue, and other minor buglets
Cherry picked from commit v1.11-1988-g82616f0 of 21-02-2012.
Reported by Panther Martin in automake bug#10848. See also
automake bug#11093.
* tests/conffile-leading-dot.test: Add a proper '$sleep' invocation,
to avoid spurious failures on fast systems without sub-second
timestamp resolutions. Add other minor related and unrelated
improvements and fixlets since we are at it.
Signed-off-by: Stefano Lattarini <[email protected]>
---
THANKS | 1 +
tests/conffile-leading-dot.test | 15 ++++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/THANKS b/THANKS
index e0c44d7..455cc62 100644
--- a/THANKS
+++ b/THANKS
@@ -269,6 +269,7 @@ Olly Betts [email protected]
Oren Ben-Kiki [email protected]
Owen Taylor [email protected]
Quentin Glidic [email protected]
+Panther Martin [email protected]
Patrick Welche [email protected]
Patrik Weiskircher [email protected]
Paul Berrevoets [email protected]
diff --git a/tests/conffile-leading-dot.test b/tests/conffile-leading-dot.test
index 1ee153f..8eaed4b 100755
--- a/tests/conffile-leading-dot.test
+++ b/tests/conffile-leading-dot.test
@@ -31,9 +31,7 @@ AC_CONFIG_FILES([./foo:a.in:b.in:c.in])
AC_OUTPUT
END
-echo foo = barbarbar > Makefile.am
-
-touch a.in b.in c.in
+touch a.in b.in c.in Makefile.am
$ACLOCAL
@@ -46,16 +44,19 @@ grep "^configure\.in:4:.* omit leading '\\./'" stderr
grep "^configure\.in:4:.*remake rules might be subtly broken" stderr
# Check that our warning was actually justified.
+sed 's/^AM_INIT_AUTOMAKE/&([-Wall -Wno-unsupported])/' <configure.in >t
+mv -f t configure.in
+rm -rf autom4te*.cache
+$ACLOCAL
$AUTOCONF
$AUTOMAKE -Wall -Wno-unsupported
./configure
$MAKE
-grep barbarbar Makefile
-# No need to sleep here, configure did that for us already.
-echo foo = bazbazbaz > Makefile.am
+$sleep
+touch Makefile.am
# Check that remake rules do truly break -- otherwise automake is
# giving a bogus warning.
-$MAKE 2>stderr && { cat stderr >&2 Exit 1; }
+$MAKE 2>stderr && { cat stderr >&2; Exit 1; }
cat stderr >&2
grep "config\\.status:.*invalid argument.*Makefile" stderr
--
1.7.9
>From 8bf5cacff594974000979c5b70e33ebbcfcde29a Mon Sep 17 00:00:00 2001
Message-Id: <8bf5cacff594974000979c5b70e33ebbcfcde29a.1332766224.git.stefano.lattar...@gmail.com>
From: Bruno Haible <[email protected]>
Date: Mon, 26 Mar 2012 14:44:05 +0200
Subject: [PATCH] vala tests: fix spurious failures with older valac (<=
0.7.2)
See automake bug#11093.
The Vala compiler before the 0.7.3 release does not support the
'--profile' option. But some of our tests were relying on it, so
skip those tests if the detected Vala compiler is too old.
* tests/vala-vpath.test, tests/vala-mix.test, tests/vala-mix2.test
(configure.in): Require vala version >= 0.7.3 in AM_PROG_VALAC call.
Co-authored-by: Stefano Lattarini <[email protected]>
Signed-off-by: Stefano Lattarini <[email protected]>
---
tests/vala-mix.test | 2 +-
tests/vala-mix2.test | 2 +-
tests/vala-vpath.test | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/vala-mix.test b/tests/vala-mix.test
index 73a07d9..012b36a 100755
--- a/tests/vala-mix.test
+++ b/tests/vala-mix.test
@@ -24,7 +24,7 @@ set -e
cat >> configure.in <<'END'
AC_PROG_CC
AM_PROG_CC_C_O
-AM_PROG_VALAC
+AM_PROG_VALAC([0.7.3])
AC_OUTPUT
END
diff --git a/tests/vala-mix2.test b/tests/vala-mix2.test
index 88d2818..298f88d 100755
--- a/tests/vala-mix2.test
+++ b/tests/vala-mix2.test
@@ -25,7 +25,7 @@ set -e
cat >> configure.in <<'END'
AC_PROG_CC
AC_PROG_CXX
-AM_PROG_VALAC
+AM_PROG_VALAC([0.7.3])
AC_OUTPUT
END
diff --git a/tests/vala-vpath.test b/tests/vala-vpath.test
index 8f2b677..311eb3a 100755
--- a/tests/vala-vpath.test
+++ b/tests/vala-vpath.test
@@ -25,7 +25,7 @@ set -e
cat >> configure.in << 'END'
AC_CONFIG_SRCDIR([hello.vala])
AC_PROG_CC
-AM_PROG_VALAC([0.7])
+AM_PROG_VALAC([0.7.3])
AC_OUTPUT
END
--
1.7.9
