On Wednesday, February 02, 2011 21:49:38 Chet Ramey wrote: > On 2/2/11 6:27 PM, Mike Frysinger wrote: > > - lib/glob/smatch.c needs externs.h for mbsmbchar. seems like externs.h > > could do with including bashtypes.h/command.h/general.h too since it > > needs basic types from all of those. > > Or an extern declaration for mbsmbchar, to avoid having to include other > files.
that defeats the whole point of having a single extern line. changing the header and matching func definition wouldnt automatically catch random externs sprinkled over the tree and could result in an arbitrarily crashing binary that showed no build errors or warnings. -mike
signature.asc
Description: This is a digitally signed message part.
