http://sourceware.org/bugzilla/show_bug.cgi?id=13410

--- Comment #13 from Vidya Praveen <childbear0 at gmail dot com> 2012-02-03 
08:30:31 UTC ---
(In reply to comment #12)
> The patch reads:
> +  /* If 'shrinkable' is FALSE, do not shrink by deleting bytes while
> +     relaxing. Such shrinking can cause issues for the sections such 
> +     as .vectors and .jumptables. Instead the unused bytes should be 
> +     filled with nop instructions. */
> +  bfd_boolean shrinkable = TRUE;
> +
> +  if (!strcmp (sec->name,".vectors")
> +      || !strcmp (sec->name,".jumptables"))
> +    shrinkable = FALSE;
> Shouln't this also cover .jumptables* and .progmem.gcc* ?
> avr-gcc puts its jumptables into .progmem.gcc_sw_table for instance.
> Relaxing must not do harm to them.

I didn't analyze the which other sections that might require this, however I
assumed such requirements will be there. This is one of the reason why I moved
out the check outside the loop, so the such additions are easy and in one
place. Are there any other sections that might require to be here?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

Reply via email to