Le 1 sept. 2012 à 18:38, Eric Blake a écrit : Hi Eric,
> I got the following error while building the latest master branch of > bison.git: > > CC src/bison-parse-gram.o > src/parse-gram.y: In function 'add_param': > src/parse-gram.y:779:5: error: implicit declaration of function > 'isspace' [-Werror=implicit-function-declaration] > > This patch fixes it for me, but I don't know if you instead want to > patch system.h: Jim is already on this, his patch will certainly be applied soon. > I didn't check what other branches are active, to see if they also need > the patch. maint and master are the two active branches. > But while looking at system.h, I did notice one other thing; > it has: > > #if HAVE_SYS_TYPES_H > # include <sys/types.h> > #endif > > But because bison uses gnulib, we are guaranteed that: > 1. <sys/types.h> always exists, so the use of HAVE_SYS_TYPES_H is pointless > 2. these days, POSIX 2008 requires that most headers be self-contained > (that is, you need not include <sys/types.h> prior to another header, > but just use the other header, and the types you need will still be > declared); gnulib enforces this rule, making it quite portable to > compile without ever explicitly including <sys/types.h>. > > That is, I think you could delete those three lines with no ill effects. OK, I will do. Is this the only header like this? I'm also surprised that the gnulib's syntax-checks did not catch this. Thanks!
