Removing the pling from the if() statement had the desired effect -- no more lingering .cfsaved files.
-Paul > As a followup, I dug into the diffs in image.c between 2.1.20 and 2.1.21 > (image.c appears to handle the copy: directive and the related backups). > An important change between 2.1.20 and 2.1.21 appears to be this: > > http://svn.iu.hio.no/viewcvs/trunk/src/image.c?rev=276&r1=239&r2=276 > > Suprise! It's an if() statement related to a backup list of some kind. > > I am by no means a cfengine developer, so I may be completely off base > here, but it looks like the VREPOSLIST is a recently added feature > (added in rev 233 as noted here: > http://svn.iu.hio.no/viewcvs/trunk/src/image.c?rev=276&r1=233&r2=276) > > As shown with the context in the second link here, before revision 276, > the backup (aka .cfsaved) was removed if the "repository" feature was > enabled. Mark added the if() statement so that the .cfsaved file was > only deleted if the copy to the repository was successful. However, the > logic appears wrong (the pling should not be there). Mark seems to have > caught it (based on the first diff link) but that fix did not make it > into 2.1.21. > > I'll try removing the pling from line 1582 of image.c and see if that > fixes the problem. > > > -Paul > > Paul Krizak wrote: >> I'm replying to this thread and CCing the help list because there has >> been no response... >> >> I'm seeing this same issue with 2.1.21 -- the behavior is definitely >> different than 2.1.20. This unexpected behavior is having unusual and >> difficult to track down effects in our cluster at AMD, including Ralph's >> mention of /etc/cron.*/... >> >> Any idea what's going on? Is there a patch? A workaround? Some simple >> option that needs to be changed? >> >> I'd really rather not insert tidy: statements after every copy: >> statement in our (enormous) cfengine configuration. >> >> -Paul >> >> >> Ralph Angenendt wrote: >>> Orion Poplawski wrote: >>>> [EMAIL PROTECTED] etc]# ls nsswitch.conf* >>>> nsswitch.conf nsswitch.conf.cfsaved >>>> >>>> It still copies it to /var/cfengine/saved/ though: >>>> [EMAIL PROTECTED] etc]# ls /var/cfengine/saved/_etc_nsswitch.conf.cfsaved >>>> /var/cfengine/saved/_etc_nsswitch.conf.cfsaved >>> I'm seeing exactly the same behaviour on 2.1.21. Which is great in case >>> of files unter /etc/cron.*/ ... >>> >>> Cheers, >>> >>> Ralph >>> >>> >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Bug-cfengine mailing list >>> [email protected] >>> http://cfengine.org/mailman/listinfo/bug-cfengine >> _______________________________________________ >> Help-cfengine mailing list >> [email protected] >> https://cfengine.org/mailman/listinfo/help-cfengine >> > > _______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
