On Jan 9, 2008, at 10:03 AM, Eric Searcy wrote: > With regards to whitespace, its just a habit to clean trailing > whitespace or to fix the four-space indents that some people have > put in when I'm working in the same vicinity, so that my (properly > indented) code lines up with the surrounding code (like in the > switch block). When I tried submitting my changes in separate > patches (including whitespace in its own patch) Mark asked for a > single patch. Anyhow, I removed the ws-only blocks, but left the > fix for the switch statement.
Or if you are submitting a patch for functionality review, use 'diff - w' and then supply the same patch with the whitespace for inclusion into CVS. But anyway, I was just whining ;-) FYI: I thought over your comment about the missing %s a few times, and first leaned towards your idea and then went back. More obvious == less confusion. In fact, it might be a good idea to put a complaint/warning in there if no %s is found in the string. Both of the above comments based only on what we always see on the help list ;-) -- Jo Rhett senior geek Silicon Valley Colocation Support Phone: 408-400-0550 _______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
