"James Youngman" <[EMAIL PROTECTED]> wrote: > On Feb 16, 2008 6:35 PM, Jim Meyering <[EMAIL PROTECTED]> wrote: >> Both of which are checked by running "make distcheck". > > Thanks. I was unable to do that, because at the moment, tests/cp/acl > fails on my machine. I suspect this is because I am using a VPATH > build and $PWD includes a symlink, though I have not yet had time to > investigate: > > orbital:cp$ rm acl.log; pwd ; pwd -P; grep "top_srcdir = " Makefile; > make acl.log > /home/james/source/GNU/coreutils/compile/tests/cp > /home/build/james/GNU/coreutils/compile/tests/cp > abs_top_srcdir = /home/james/source/GNU/coreutils/coreutils > top_srcdir = /home/james/source/GNU/coreutils/coreutils > FAIL: acl.log > orbital:cp$ cat acl.log > FAIL: acl.log (exit: 1) > ======================= > > grep: ../../lib/config.h: No such file or directory
Thanks for reporting that. This patch should fix it. Would you please confirm? diff --git a/tests/check.mk b/tests/check.mk index 48cffa4..8caf29d 100644 --- a/tests/check.mk +++ b/tests/check.mk @@ -44,7 +44,7 @@ TESTS_ENVIRONMENT = \ host_triplet='$(host_triplet)' \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ - CONFIG_HEADER='$(CONFIG_HEADER)' \ + CONFIG_HEADER='$(abs_top_builddir)/lib/config.h' \ CU_TEST_NAME=`basename '$(abs_srcdir)'`,$$tst \ EGREP='$(EGREP)' \ EXEEXT='$(EXEEXT)' \ BTW, you can run the lighter-weight tests with "make syntax-check". Or use make's --keep-going (-k) option: make -k distcheck _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
