On 7/4/08, Jim Meyering <[EMAIL PROTECTED]> wrote: > "Halesh S" <[EMAIL PROTECTED]> wrote: >> The last patch has missied for no-args. >> The attached patch will fix the issue. > > Thanks for the work and patches. > However, before I can accept it, here are some things you'll need to do: >
> - also work with -l (long_pinky)
Done and tested.
> - "pinky" (with no arguments) should not fail when there are no entries.
Done and tested.
> - use error (EXIT_FAILURE, 0,... , not fprintf (stderr...+exit 1.
Done.
> - don't use negation in a variable name: use "bool match = false;", not...
Done.
> - use indentation that's consistent with surrounding code
Followed.
>
> Also, please read the guidelines in the relatively new file, HACKING.
> (get a copy via "git clone git://git.sv.gnu.org/coreutils") In
> particular, you'll have to write a ChangeLog entry that will serve as
> commit log message and to run "git format-patch" to produce the patch
> you eventually send.
>
I am not able to it..
I have attached a patch. If possible you do the git.
Thanks,
Halesh
pinky.c.patch
Description: Binary data
_______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
