-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 8/28/2008 7:00 AM: >> In your second patch, why is version.h generated? In >> reality, only version.c needs to be generated, since it is the only file >> with varying contents. > > I did that to keep the declaration and definition "close". > It's not essential, but feels a little cleaner.
Fair enough. > Using version.o would be sufficient, but would require unmaintainable > changes to coreutils' src/Makefile.am. Using a library seems like the > easiest way to ensure each binary gets the new symbol without enumerating > the dependency manually in src/Makefile.am. Good point. So other projects, with fewer programs, can skip the convenience library aspect of your solution. > > For now, my aim was solely to avoid ccache waste. > And as long as the compiled code doesn't *use* the changing > symbols that's just fine. > > Of course, it'd be even better if config.h didn't have to change > at all, but to get there, we'll have to change or override > m4 macros that emit *VERSION definitions. > > One step at a time ;-) Your patch meets the stated goal, so I think it's fine to check in. If nothing else, it made me investigate using ccache on my machine. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAki3WMoACgkQ84KuGfSFAYDOEACfV53ijqzdatdCjAHjHIl9X/aF RI8An3qxCfhvqp5H++LvlH6RW8a5oaaB =FRA6 -----END PGP SIGNATURE----- _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils
