Kamil Dudka <[EMAIL PROTECTED]> wrote:
> Hello Jim,
>
> after your agreement last week I am sending the patch for cp/mv xattr support.
> Any feedback is wellcome...
Please modernize xattr.m4. E.g., use AS_HELP_STRING,
fix the underquoting errors, a few of which are noted below.
There is more than a little duplication in the set-up for
the two added tests. Please consider combining them into a single file.
In the tests, use grep -F, not fgrep.
Please use "char const *", not "const char *", and with other types.
Change this both in the commit log 1-line summary and in NEWS:
s/xattr support/add xattr support/
In the commit log, attribute Andreas.
Also, give a URL for his unmodified patch, if you can.
> @@ -7372,6 +7372,9 @@ Preserve in the destination files
> any links between corresponding source files.
> @c Give examples illustrating how hard links are preserved.
> @c Also, show how soft links map to hard links with -L and -H.
> [EMAIL PROTECTED] xattr
> +Preserve extended (xattr) attributes if coreutils are compiled with xattr
s/are/is/
> +support.
...
> +AC_DEFUN([gl_FUNC_XATTR],
> +[
...
> + AC_CHECK_HEADERS(attr/error_context.h attr/libattr.h)
AC_CHECK_HEADERS([attr/error_context.h attr/libattr.h])
> + if test "$ac_cv_header_attr_libattr_h" = yes \
> + && test "$ac_cv_header_attr_error_context_h" = yes; then
Drop the unnecessary double quotes above:
if test $ac_cv_header_attr_libattr_h = yes \
&& test $ac_cv_header_attr_error_context_h = yes; then
> + use_xattr=1
> + else
> + use_xattr=0
> + fi
> + AC_DEFINE_UNQUOTED(USE_XATTR, $use_xattr,
Fix quoting:
AC_DEFINE_UNQUOTED([USE_XATTR], [$use_xattr],
etc. (likewise below)
> + [Define if you want extended attribute support.])
> + xattr_saved_LIBS=$LIBS
> + AC_SEARCH_LIBS(attr_copy_file, attr,
> + [test "$ac_cv_search_attr_copy_file" = "none required" ||
> LIB_XATTR=$ac_cv_search_attr_copy_file])
> + AC_SUBST(LIB_XATTR)
> + AC_CHECK_FUNCS(attr_copy_file)
> + LIBS=$xattr_saved_LIBS
> + fi
> +])
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
