Pádraig Brady <p...@draigbrady.com> wrote: > Kamil Dudka wrote: >> On Monday 16 February 2009 11:07:56 you wrote: >>> Is 128KiB of stack OK? >>> I noticed this related email from Eric: >>> http://lists.gnu.org/archive/html/m4-patches/2008-08/msg00001.html >> The idea of 64KiB on stack allocated buffers was taken from RHEL4 >> implementation. But you are right - it can be problem on some platforms. >> In this case it should be allocated dynamically. Any other ideas? > > I think 2 malloc'd buffers would be better. > Also 4KiB it probably enough, as files will usually differ > in the first 4096 bytes and if not readahead will be done > underneath if appropriate.
I prefer to avoid the malloc calls (two fewer ways to fail), but if there's a good enough reason, it's fine with me. _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils