Hello,
as reported in rhbz #496142 by Eric Sandeen, mv produces a lot of
unwanted messages when moving files to filesystem without xattr support.
I guess mv selinux/xattr diagnostic error messages should be reduced as
is done for cp -a, attached patch should do that.

Greetings,
         Ondřej Vašík
From 02c4948b688d55dc28b9adad3ebe7ef2afbe3c4b Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <ova...@redhat.com>
Date: Fri, 17 Apr 2009 11:00:35 +0200
Subject: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

src/mv.c: Set reduce_diagnostics to reduce unwanted message spam
          (reported by Eric Sandeen in rhbz #496142)
---
 NEWS     |    3 +++
 src/mv.c |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/NEWS b/NEWS
index d8ffde0..0d2e524 100644
--- a/NEWS
+++ b/NEWS
@@ -42,6 +42,9 @@ GNU coreutils NEWS                                    -*- outline -*-
   LS_COLORS environment variable. To disable it you can add something like
   this to your profile: eval `dircolors | sed s/hl=[^:]*:/hl=:/`
 
+  mv: do not produce diagnostic errors for preserving xattr's to
+  prevent message spam on file systems without xattr support.
+
 
 * Noteworthy changes in release 7.1 (2009-02-21) [stable]
 
diff --git a/src/mv.c b/src/mv.c
index 73bd3ef..746ac7c 100644
--- a/src/mv.c
+++ b/src/mv.c
@@ -116,7 +116,7 @@ cp_option_init (struct cp_options *x)
   x->preserve_mode = true;
   x->preserve_timestamps = true;
   x->preserve_security_context = selinux_enabled;
-  x->reduce_diagnostics = false;
+  x->reduce_diagnostics = true;
   x->require_preserve = false;  /* FIXME: maybe make this an option */
   x->require_preserve_context = false;
   x->preserve_xattr = true;
-- 
1.5.6.1.156.ge903b

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy

_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils

Reply via email to