Re: [PATCH] du now diagnoses cycles, rather than ignoring them

[Jim Meyering]

Eric Blake wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>
>> +      if (symlink_deref_bits == FTS_PHYSICAL
>> +          || (symlink_deref_bits == (FTS_COMFOLLOW | FTS_PHYSICAL)
>> +              && ent->fts_level != FTS_ROOTLEVEL))
>
> Can't this be simplified?
>
>      if (symlink_deref_bits == FTS_PHYSICAL
>          || (symlink_deref_bits == FTS_COMFOLLOW
>              && ent->fts_level != FTS_ROOTLEVEL))

I don't see how, since with -D, it does this:

        case 'H':  /* NOTE: before 2008-12, -H was equivalent to --si.  */
        case 'D':
          symlink_deref_bits = FTS_COMFOLLOW | FTS_PHYSICAL;
          break;