On 04/12/2012 03:04 PM, Jim Meyering wrote: > Pádraig Brady wrote: > ... >> So thinking a bit more about this, >> and given the confusion expressed in the above bug report, >> perhaps it's best to change --attributes-only to >> _not_ truncate existing files? >> >> I think scripts relying on the truncation behavior >> of this relatively new feature would be very rare, >> and the non truncating behavior is more generally useful. >> >> Patch to implement this change is attached. > > Thanks for doing this. > I prefer the new non-truncating behavior, too.
Cool. I'll push with your clean-ups later on. Eric is it OK to close this bug, or are there cases not handled yet? (I didn't fully understand your suggestion TBH). thanks for the review, Pádraig.