On 01/06/16 01:38, Assaf Gordon wrote:
Hello Karl and all,
On May 31, 2016, at 19:15, Karl Berry <[email protected]> wrote:
[...]
I'm not sure what you mean by [...]. The %lu?
Are you proposing to just add the word "sort"? That's not needed IMHO.
I was suggesting exactly that :)
Also, the word "key" appears in few other messages, the attached patch adds
"sort" to them all. This is of course just a suggestion, and we can use another syntax
like the one you listed.
Attached are 3 patches, not finalized but good as a starting point for comments.
1. rephrase "key" with "sort key". Perhaps this is superfluous - thoughts ?
2. add a bit more verbose progress information to the 'sort-debug-warn.sh' test
- just so it'll be easier to discuss to the changed messages.
3. removes the 'maybe_space_aligned' and modifies the condition a bit.
I'm 50:50 on 1.
2 and 3 are good to push.
thanks!
