On 14/09/2025 07:07, Collin Funk wrote:
Collin Funk <[email protected]> writes:
That is my hypothesis at least, will need to write a patch to test it.
Looks like my hypothesis was correct. I ran the CI with the attached
patch, and everything passes.
I'll hold off pushing until Pádraig checks it. Since he may want to
revisit his previous commit and handle things differently.
This looks good thanks.
valgrind or ASAN detects the UMR,
so we would definitely have caught this before release:
$ valgrind src/basenc --base32 -d /dev/null
Conditional jump or move depends on uninitialised value(s)
at 0x40117B: decode_ctx_finalize (basenc.c:358)
by 0x403060: do_decode (basenc.c:1559)
by 0x4038DD: main (basenc.c:1770)
There may be more cleanups I might do in this area,
but we should commit this fix anyway.
Marking this as done.
thanks!
Padraig.
p.s. an ASAN build would be good for CI
