On 02/09/2026 20:47, Paul Eggert wrote:
On 2026-09-02 10:12, Pádraig Brady wrote:
we should remove ENOSPC from being considered as a terminal error
Yes, but it's not just ENOSPC; it's also EDQUOT etc. That is, as far as I can
see, no error from an allocation group necessarily means there must be an error
from an ordinary read+write copy.
Don't we need to be careful with some errors as per
https://github.com/coreutils/coreutils/commit/f6c93f334
https://bugs.gnu.org/60489 ?
Also this removes partially cloned files on error,
rather than just empty files. ?
Also, it strikes me that if this sort of thing happens, people might want to
know details when debugging.
So I installed the attached. The first treats EDQUOT etc. like ENOSPC; the
second reports the errno when --debug is used.
I'm a little worried about about giving worrying errors here
rather than an abstract "unsupported". Perhaps map is_CLONENOTSUP()
to "unsupported" and others to their errno?
cheers,
Padraig
