Conrad T. Pino wrote: >I added "lib/lstat.c" because linker didn't have definition for external >symbol "_rpl_lstat" and a grep found only 1 definition. I had seen this >commit to "windows-NT/config.h" files: >https://ccvs.cvshome.org/servlets/ReadMsg?list=cvs&msgNo=3881 >which I assume meant the reference to "rpl_lstat" was intentional. > >I've always assumed commits to "windows-NT" config files reflected a well >considered plan so I often don't examine the committed changes other than >noting the file names. I now see room for process improvement. What are >your thoughts? > >
Well-considered, perhaps, but without a test platform it can be challenging to verify that I did not make any mistakes. In this case, I thought I knew what I was doing and was just trying to save you some work. Apparently I neglected to consider that the #include "lstat.h" was going to override my windows-NT/config.h changes in this case. Sounds like the `#define lstat stat' can be removed from windows-NT/config.h.in.footer in conjunction with the other changes we discussed. Please feel free to review any committed changes that you see fit to and discuss them on bug-cvs. :) Regards, Derek _______________________________________________ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
