Antonio Diaz Diaz wrote:
Version 1.6-rc1 of GNU ddrescue is ready for testing here
http://es.geocities.com/ant_diaz2001/ddrescue-1.6-rc1.tar.gz
Please, test it and report any bugs you find.
Looks good on Cygwin.
Some suggestions:
- Add a brief description of the --fill "types" parameter to --help
output and manpage.
- Probably add my F_NOCACHE patch to support --direct on Darwin :-)
- Add some warning to the doc that old logfiles cannot be used to
continue a rescue operation.
- Print a more informative error message when reading a old logfile.
1.6-rc1 prints: "error in logfile ..., line 3."
(or even better: Accept old logfiles as input)
BTW: The trailing "\n" in the sscanf() format string has no effect.
Logfiles with trailing chars after the type char are accepted.
If strict syntax checking is desired, "%n" can be used to check the
number of chars actually parsed:
int nc = -1;
std::sscanf( line, "%lli %c\n%n", &_current_pos, &ch, &nc );
assert( nc == -1 || nc == strlen( line ) );
if ( nc < 0 )
// \n not seen
Checking of sscanf() return value is not necessary then.
Best regards,
Christian
_______________________________________________
Bug-ddrescue mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-ddrescue
