Hello Christian,

Christian Franke wrote:
...
New attached new patch avoids the union, does strict index checks and ensures zero termination. It now also allows that an ATA IDENTIFY string is only in VendorId or ProductId which occasionally happened with some older drives.
...

Could the patch possibly be included into 1.21 ?

First of all, thanks for the patches. I appreciate your effort, but the windows way of getting a device ID is ugly as hell. I would have accepted something in the line of linux or haiku:

ioctl(...)
id_str = (const char *)ptr;

Instead windows seems to need all kinds of hacks and obscure constructs to achieve the same result.

So I think that from now on I'll accept only simple patches for non_posix.cc, similar to the two already included there.


Thanks and regards,
Antonio.

_______________________________________________
Bug-ddrescue mailing list
Bug-ddrescue@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-ddrescue

Reply via email to