On 08/18/10 17:14, Philipp Thomas wrote:
> IMO
> the error in 2.8.7 is this code:
>
> #if O_BINARY
> /* Use binary I/O when reading and writing data (--binary).
> On POSIX hosts, this has no effect. */
> static bool binary;
> #else
> enum { binary = true };
> #endif
I'm glad to hear that the bug is not present in
diffutils 3.0. But I'm quite skeptical that the error
occurs in the code that you quote, since you're
quoting the 3.0 version of the code, not the
2.8.7 version.
> Which I will fix by setting binary to false instead of true.
I'm also skeptical of this fix. Perhaps it makes
one symptom go away in one test case, but it's quite
possible that it causes problems elsewhere.
