Pavel Raiskup writes: 
> One nit from me would be that the name of $autoconf variable is
> not luckily chosen because it is not running autoconf.  I would chose
> something like $tracer (or $autom4te)?  But it is a nit - don't see any
> blocker in these patches.

I agree with that, but variable names are a matter of taste.

Also another comment for the patch:
----------------------------------------------------------------------
+autoconf="autom4te --no-cache --language=Autoconf-without-aclocal-m4"
+
----------------------------------------------------------------------
is the "--no-cache" flag really needed? It's just a comment, but maybe I
should be quiet because I do not have a deep knowledge about autoconf.

Best regards,
Miguel


Reply via email to