Daiki Ueno <[email protected]> writes: > Miguel Ángel Arruga Vivas <[email protected]> writes: > > > I actually prefer arglist_parser functions family, because It eases a > > little bit GtkBuilder implementation, but there is no real problem,
Nevermind. It is not optimal because... > However, it looks a bit hacky to me that arglist_parser functions are > used without other callshape API functions, unlike other parsers. ... using keyword splitting is as hacky as this for a stream parser, as you noticed... > though it might not fit well with the SAX-style parser. ... here. Numbered arguments does not fit in xml parsing. I think you (and Bruno when he did It) were right with the call remember_a_message here. > > Also, for the tests patch, should I split msgctxt extraction test > > (xgettext-glade-5) and atkproperty test case (xgettext-glade-4) in two > > commits? > > Yes, please. The atkproperty test case is not related to the context > support, right? Also perhaps it might be good to add a wrong element to > the xgettext-glade-5 to test the failure case. Done. See the next mail (and or my github repo -> glade_fixes). Best regards, Miguel
