Stefano Lattarini <[email protected]> writes: > Hi Daiki. Hope you won't mind some suggestions from a non-contributor; > anyway, since you can easily ignore such suggestions, I think there is > no problem in brining them up :-)
Not at all. Thanks for all the help :-) >> * git submodule migration >> Although this won't affect the installed system, it will simplify the >> release procedure a bit. >> > +1 from me here, absolutely > > And once that is done, you might also want to try to have the > bootstrapping process delegate some more work to the well-tested > 'bootstrap' script that is provided by gnulib. That would be nice, but I'm wondering if 'bootstrap' fits well in the Gettext source code structure. Currently 'autogen.sh' calls "gnulib-tool --import" multiple times to populate Gnulib files under different sub-directories and calls automake/autoconf/libtoolize for each sub-directory. Can 'bootstrap' be used for this slightly uncommon use-case? Perhaps an idea might be to have copies of 'bootstrap' in each sub-directory and call them from the top-level 'bootstrap'. > - Cosmetic issue: in the heading comments, "1.13" is not reported > among the supported Automake versions. > > Finally, it would also be nice to update all the Gettext code to use > $(MKDIR_P) instead of the deprecated $(mkdir_p) ;-) Sure, thanks for reminding. Regards, -- Daiki Ueno
