Chusslove Illich <[email protected]> writes: > I've tested the patched xgettext on a number of KDE software modules, > using the full ensemble of --flag options, and everything seems to > work as expected. So, at the moment, I have nothing to add or change.
Thanks for testing. Pushed as: http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=5c2d4fc2 For reference, changes from v1 are: - split KUIT handling from format-kde.c to format-kde-kuit.c - add documentation - remove parser->is_unlikely_intentional callback, which turned out not necessary > While testing, some messages did still end up without flags, but that was > due to a separate aspect I wrote about earlier: > https://lists.gnu.org/archive/html/bug-gnu-utils/2009-04/msg00010.html Yes, the --kde option is only effective for C++: http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/src/xgettext.c#n3733 >> [...] and maintain it in gettext, since it is you who invented the stuff >> in the KDE side :-) > > Sure, I'd be happy to. > > But this doesn't include adding and keeping up-to-date a bunch of default > keywords, does it? :) I'm not strongly for or against that. I think this could be done by adding a bunch of xgettext_record_flag calls to x-c.c:init_flag_table_c. If they are useful, could you propose a patch? >> Also it might look a bit surprising that the 3rd and 4th string is marked >> as kde-format, even if it doesn't contain a format directive. However, >> this is the original behavior, and should be addressed separately. > > Well, it was the point that all strings get one of two kde-* format flags, > so I'm not sure I understand the remark. I mean, the behavior is surprising > from the point of view of common Gettext usage, but for this kind of usage > (format directives always processed), it is in accordance with that passage > from the Gettext manual I cited. Ah, right. I now see that by re-reading your mail. Perhaps the documentation could be a bit clearer, by telling that the --flag option and the "xgettext:" comment have the same effect. Regards, -- Daiki Ueno
