Fair enough. Let me work on that patch. Will get back in a couple of days.

-dhruva


On Tue, Aug 26, 2014 at 3:45 PM, Shigio YAMAGUCHI <[email protected]> wrote:

> 2014-08-27 0:59 GMT+09:00 dhruva <[email protected]>:
>
>>
>> Generating a list of changes and putting them in 3 separate files is an
>> overhead. Look from a usability perspective, we will have to find all
>> added, deleted and modified files and put them in 3 different files.
>>
>> In the current approach (my patch), we just put all the 3 types into the
>> same file and it is easy to generate that file. Since I use perforce (p4)
>> SCM at work, I just do "p4 opened|awk "STRIP_SOME_DEPOT_PATH" '{print $2}'
>> | gtags -D -i -f -"
>>
>> Overall, I would give priority to usability over slight improvement in
>> performance. Doing it in batch mode gives use sufficient performance boost
>> with no impact on usability.
>>
>>
> OK. But there is no necessity of withdrawing the optimization.
> How about adding the 4th '--update' option?
>
> --update-add: added files
> --update-delete: deleted files
> --update-change: changed files
> --update: added/deleted/changed files
>
> I believe '--update' == '-D -i -f'
> The following two are almost the same.
>
> $ gtags --update-add=added --update-delete=deleted --update-change=changed
> $ cat added deleted changed | gtags --update=-
>
> Shigio
>
> --
> Shigio YAMAGUCHI <[email protected]>
> PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3
>
_______________________________________________
Bug-global mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-global

Reply via email to