-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Paul Eggert wrote:
>First, already we have something bogus: that __BEGIN_DECLS. It must >be protected by "#ifdef _LIBC", since random C environments don't have >it. Similarly for __END_DECLS. Done. >The simplest fix would be to do something like this: > >#if defined _LIBC || HAVE_SYS_CDEFS_H ># include <sys/cdefs.h> >#endif > >with the appropriate change to glob.m4. Actually, this change doesn't appear to be necessary once I protect the __BEGIN_DECLS and __END_DECLS stuff. I've removed the #include of <sys/types.h>. >But let's step back a second. Why are we worried about building >gnulib glob.c under glibc? It will never happen, right? So perhaps >we needn't worry about this problem at all. Won't it? I thought the idea was that when you and I settled on something that looked good I would attempt to send it back to the libc folks so that the files wouldn't need to be maintained separately. So far, our work contains at the least some cleanup, a bug fix, and an efficiency improvement that should be useful in libc. >With that in mind, how about if we simply remove those #undef's? If >the problem recurs we can put them back in again. Done. Patch still delayed until I'm done with my email. Regards, Derek -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCijnMLD1OTBfyMaQRAklUAKDo25YXS7Hk5kqlYe1AzXICeBBLfwCfahXg oD3soIvk5Shqw50Mfm4dgRY= =/2W5 -----END PGP SIGNATURE----- _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
