Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Simon Josefsson <[EMAIL PROTECTED]> wrote: >>> Ok to install? >>> >>> Comments appreciated, of course. >> >> Hi Simon, >> >> In this function, >> >> +rijndael_rc >> +rijndaelMakeKey (rijndaelKeyInstance * key, rijndael_direction direction, >> + int keyLen, char *keyMaterial) >> >> the keyMaterial parameter should be `const'. >> >> And in this one, both key and input be const, too. >> There are others like this. > > I have fixed this throughout the file. I changed the type of KEYLEN > to size_t as well. > > Thanks! > >>> +int >>> +rijndaelPadEncrypt (rijndaelCipherInstance * cipher, >>> + rijndaelKeyInstance * key, unsigned char *input, >>> + int inputOctets, unsigned char *outBuffer)
Hmm... looking at that in isolation, I wonder if `inputOctets' should be of type size_t, too? Also, from a formatting standpoint, there should be no space after the `*'s above, e.g.: +rijndaelPadEncrypt (rijndaelCipherInstance *cipher, + rijndaelKeyInstance *key, unsigned char *input, + int inputOctets, unsigned char *outBuffer) If you're using GNU indent, you can make it do the right thing by adding lines like these to ~/.indent.pro -TrijndaelCipherInstance -TrijndaelKeyInstance for all affected types. _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
