Bruno Haible <[EMAIL PROTECTED]> wrote: > There is an abstraction violation in lib/acl.h: While the functions declared > in this file have a platform independent API, and coreutils (copy.c, cp.c, > ls.c) > uses only this platform independent API, it also includes part of the platform > dependent include files: <sys/acl.h> (on Linux, this is not all of the API), > and defines GETACLCNT (a Solaris specific hack).
Hi Bruno, > IMO there's no reason for this code to be in "acl.h". I propose to move it > to "acl-internal.h". > > OK to commit? > > 2008-05-22 Bruno Haible <[EMAIL PROTECTED]> > > * lib/acl.h: Don't include <sys/acl.h>. > (GETACLCNT): Move fallback to lib/acl-internal.h. > * lib/acl-internal.h: Include <sys/acl.h> here. > (GETACLCNT): New macro fallback, moved here from lib/acl.h. Sure. That looks fine. Thanks.
