-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 On 03/29/2010 02:56 AM, Jim Meyering wrote: > Javier Villavicencio wrote: >> I think you may have mixed up the two patches I reported against grep > > Think again ;-)
:+) I just did, you're right. > >> bug 29358, so, to clarify: >> That above is actually the patch that made most sense to me against the >> EXCLUDE_INCLUDE logic, as in: excluded_file_pattern_p should return >> !excluded on string match, not depending on the value excluded gets from >> options. >> >> The fix for GLOB matching is the second patch to grep's main.c, that >> just adds the EXCLUDE_WILDCARDS option to add_exclude(). > > Both are required. > If we don't use exclude_fnmatch properly, then --include=GLOB > doesn't work. If we don't specify EXCLUDE_WILDCARDS, then > grep doesn't even call exclude_fnmatch. > Yep, at some point debugging this I quite broke it in two separate things, _INCLUDE and _WILDCARDS, this one is indeed for both. Sorry for the spam. Salu2, Javier. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEAREDAAYFAkuwjD8ACgkQgvV6MZSadQqN3ACfW38bX2XBQxAan1QDBYekeZJN Lx8AoIk2O0CyuC4Q/YDNjErTlj9nY6+R =bRqI -----END PGP SIGNATURE-----
