Looks much better now. 'make check' now reports: make[4]: Entering directory `/usr/local/Floss/acltestdir2/gltests' PASS: test-file-has-acl.sh PASS: test-set-mode-acl.sh unknown permission ":0" PASS: test-copy-acl.sh PASS: test-binary-io.sh unknown permission ":0" PASS: test-copy-file.sh PASS: test-errno PASS: test-fcntl-h PASS: test-ftello.sh PASS: test-ftello2.sh PASS: test-ftello3 PASS: test-lseek.sh PASS: test-lstat PASS: test-mbrtowc1.sh Skipping test: no french Unicode locale is supported SKIP: test-mbrtowc2.sh Skipping test: no traditional japanese locale is supported SKIP: test-mbrtowc3.sh Skipping test: no transitional chinese locale is supported SKIP: test-mbrtowc4.sh Skipping test: no french Unicode locale is supported SKIP: test-mbsinit.sh PASS: test-open PASS: test-quotearg-simple Read 68 from /etc/resolv.conf... FAIL: test-read-file PASS: test-stat PASS: test-stdbool PASS: test-stddef PASS: test-stdint PASS: test-stdio PASS: test-stdlib PASS: test-strerror PASS: test-string PASS: test-symlink PASS: test-sys_stat PASS: test-time PASS: test-unistd PASS: test-verify PASS: test-verify.sh PASS: test-wchar PASS: test-wctype PASS: test-xalloc-die.sh ====================== 1 of 33 tests failed (4 tests were not run) ====================== make[4]: *** [check-TESTS] Error 1 make[4]: Leaving directory `/usr/local/Floss/acltestdir2/gltests'
-----Original Message----- From: Bruno Haible [mailto:[email protected]] Sent: Sunday, October 03, 2010 2:44 PM To: Schmitz, Joachim Cc: 'Paolo Bonzini'; 'bug-gnulib' Subject: Re: ACLs on HP NonStop Joachim Schmitz wrote: > Two errors so far, I fixed one (hopefully correct): > diff -u ./gllib/copy-acl.c.orig ./gllib/copy-acl.c > --- ./gllib/copy-acl.c.orig 2010-10-02 21:25:58.000000000 -0500 > +++ ./gllib/copy-acl.c 2010-10-03 06:59:44.000000000 -0500 > @@ -544,7 +544,7 @@ > /* If NACLENTRIES cannot be trusted, use dynamic memory allocation. > */ > abort (); > > - if (acl ((char *) name, ACL_GET, count, entries) == count) > + if (acl ((char *) src_name, ACL_GET, count, entries) == count) > break; > /* Huh? The number of ACL entries changed since the last call. > Repeat. */ Correct, thanks. > ../gllib/libgnu.a(file-has-acl.o): In function `file_has_acl': > file-has-acl.o(.text._148709872+0x1e2): unresolved reference to > acl_nontrivial. Wrong #ifs. Please apply this additional patch. --- /tmp/acltestdir/gllib/file-has-acl.c 2010-10-03 03:07:12.000000000 +0200 +++ lib/file-has-acl.c 2010-10-03 14:41:54.000000000 +0200 @@ -292,7 +292,9 @@ # endif } -# elif USE_ACL && HAVE_ACLSORT /* NonStop Kernel */ +# endif + +#elif USE_ACL && HAVE_ACLSORT /* NonStop Kernel */ /* Test an ACL retrieved with ACL_GET. Return 1 if the given ACL, consisting of COUNT entries, is non-trivial. @@ -318,8 +320,6 @@ return 0; } -# endif - #endif
