On 10/02/2010 04:07 AM, Bruno Haible wrote:
Hi Joachim,
The problem is that the -Wcolumns=... doesn't seem to override the pragmas in
the source.
Yes, that's clear from the documentation that you pointed us to.
I'd rather see lines of 80 chars or shorter than adding pragmas all over the
place.
Not me.
Personally, I don't mind a two-pronged approach:
Lines less than 80 columns are nicer in my opinion, and we might as well
do that whether or not -Wcolumns is in effect when the end result looks
nicer. But I agree with Bruno that some lines should not be broken, as
breaking them makes them less readable, and that we shouldn't have to
worry about whether a particular commit is going to resurrect the
problem. Therefore, using the #pragma will make the code immune to
column width, whether or not we also reduce line length.
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
