On 05/24/2011 10:18 AM, Eric Blake wrote: > On 05/24/2011 10:12 AM, Sam Steingold wrote: >> Hi, >> I updated gnulib and found that it now wants to add these files to >> CLISP: >> >> src/gllib/glthread/lock.c >> src/gllib/glthread/lock.h >> src/gllib/glthread/threadlib.c >> src/gllib/strerror-impl.h >> src/gllib/strerror_r.c >> src/glm4/strerror_r.m4 >> >> I did not import any new modules. >> what has happened? > > strerror and perror now depend on strerror_r, and strerror_r depends on > locking; this was done in order to fix perror bugs (perror is not > allowed to modify the strerror static buffer).
That said, I would really like to make strerror_r's use of locking conditional on whether 'lock' is independently present. That is, for a single-threaded application, having strerror_r call strerror without locking is just fine, so the mere use of just the 'strerror' module should not drag in locking. strerror_r only needs locking if it is used in a multi-threaded application. That means that strerror-impl.h, strerror_r.c, and strerror_r.m4 will still be needed, but it would get rid of the three glthread files. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
