On 01/05/2012 09:36 AM, Stefano Lattarini wrote: >> +++ b/tests/init.sh >> @@ -255,7 +255,7 @@ compare_dev_null_ () >> return 2 >> } >> >> -if diff_out_=`( diff -u "$0" "$0" < /dev/null ) 2>/dev/null`; then >> +if diff_out_=`exec 2>/dev/null; diff -u "$0" "$0" < /dev/null`; then >> > Wouldn't it be simpler and better to leave that redirection out altogether? > The output of the test scripts should be redirected to `.log' files by the > testsuite harness, so by being more verbose we can make those files more > informative, all without cluttering the make output.
In the case of coreutils, yes. But in the case of ./gnulib-tool --with-tests --test ..., for running gnulib unit tests, there is nothing capturing the stderr, so it leaks to the output. I agree with Jim's change - init.sh is used in too many other places to blindly state that leaking stderr to all those places is reasonable, and that init.sh should be silent instead. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
