On 12 January 2012 12:55, Jim Meyering <j...@meyering.net> wrote: > Reuben Thomas wrote: > >> On 12 January 2012 02:13, Bruno Haible <br...@clisp.org> wrote: >>> >>> - In copy-file.h declare the right function name. >> >> Ah yes, I must've missed warnings for this, sorry. >> >>> - In the tests I also had to drop the test with /dev/full, since - unlike >>> /dev/null - this device does not exist everywhere. Ex.: on OpenBSD, NetBSD. >> >> Is it not possible to annotate that test as non-portable instead? >> Seems a pity to lose a test for GNU systems. > > You are welcome to restore that test. > Just guard it with a test for existence of /dev/full > so that it is silently skipped when that device does not > exist.
OK, but looking at what was actually checked in, I'm baffled. I find no tests for specific return codes from qcopy_file_preserving (grep GL_COPY gives no hits in gnulib/tests/), and I can find no test involving /dev/null (all instances I can find are redirections, not parameters to a test). Any clues? -- http://rrt.sc3d.org
