On 08/02/2012 04:49 PM, Paul Eggert wrote: > On 08/02/2012 03:40 PM, Eric Blake wrote: >> /* Store *ST's access time into *TS. */ >> static inline void >> get_stat_atime (struct stat const *st, struct timespec *ts) > > I'd rather not go that route, as the functional style is easier > to read -- in particular, it tends to avoid aliasing issues. > > In the GNU apps I'm familiar with (Emacs, coreutils, ...) > we simply disable -Waggregate-return. It a completely > anachronistic warning, since its motivation was to > support backwards compatibility with C compilers that > did not allow returning structures. Those compilers > are long dead and are no longer of practical concern.
Fair enough; that argues that 'manywarnings' should be customized to easily ditch this and other anachronistic warnings (for example, -Wtraditional, -Wlong-long) in one line, rather than making every single client repeat the same list of customizations. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
