Akim Demaille wrote: > Le 24 sept. 2012 à 09:47, Jim Meyering a écrit : > >> You're welcome to leave it as is. > > Attached the two updated patches, and another to propagate > the style where the body of ifeq and co. is indented. > >> IMHO, more important would be to remove the need to specify >> RELEASE_TYPE=... for "make upload". > > I expect the content of .prev-version must not change? So > another file would be needed. Or can we consider that > .prev-version uses are fully under control of gnulib > (build-aux/do-release-commit-and tag etc.)?
Yes, I think it would be best to leave .prev-version as containing only the version. Nice. Thanks for all of that. ACK to all three with a barely-worth-mentioning nit below. ... > Subject: [PATCH 2/4] maint.mk: factor the validation of RELEASE_TYPE > > With help from Jim Meyering. > http://lists.gnu.org/archive/html/bug-gnulib/2012-09/msg00132.html > > * top/maint.mk (_empty, _sp): Move their definition earlier. > (member-check, release-type): New. > Use the latter instead of $(RELEASE_TYPE). > Remove now useless local checks. ... > diff --git a/top/maint.mk b/top/maint.mk > index 87bbde9..07a835e 100644 > --- a/top/maint.mk > +++ b/top/maint.mk > @@ -28,6 +28,22 @@ ifneq ($(build_aux),) > set $$(_build-aux) relative to $$(srcdir) instead of $$(build_aux)") > endif > > +# Helping variables. s/Helping/Helper/