On 01/28/2013 01:14 PM, Pádraig Brady wrote:
On 12/14/2012 04:17 AM, Jim Meyering wrote:
If we're omitting "devfs", then should "devtmpfs" also be omitted?

I don't think "devtmpfs" should be marked as dummy
as there is storage associated with it.
I.E. you can write normal files to /dev and space will be consumed.

Note df already excludes most dummy file systems
by default by checking the size like:

   if (fsu.fsu_blocks == 0 && !show_all_fs && !show_listed_fs)
     return;

I'll apply the attached in a while unless there are objections.

thanks,
Pádraig.
>From 47f4ca8fe9506254200028c8a8c5fffbf1bf1161 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com>
Date: Mon, 28 Jan 2013 17:59:05 +0000
Subject: [PATCH] mountlist: don't consider "devtmpfs" as dummy

* lib/mountlist.c (ME_DUMMY_0): Remove "devtmpfs"
as there is storage associcated with it.
---
 ChangeLog       |    6 ++++++
 lib/mountlist.c |    1 -
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bb7a142..9145f2f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-01-28  Pádraig Brady  <p...@draigbrady.com>
+
+	mountlist: don't consider "devtmpfs" as dummy
+	* lib/mountlist.c (ME_DUMMY_0): Remove "devtmpfs"
+	as there is storage associcated with it.
+
 2013-01-27  Paul Eggert  <egg...@cs.ucla.edu>
 
 	futimens-tests, utimens-tests: Depend on gettext.
diff --git a/lib/mountlist.c b/lib/mountlist.c
index 51939ec..8fb7e9a 100644
--- a/lib/mountlist.c
+++ b/lib/mountlist.c
@@ -156,7 +156,6 @@
    /* for Linux 2.6/3.x */                      \
    || strcmp (Fs_type, "debugfs") == 0          \
    || strcmp (Fs_type, "devpts") == 0           \
-   || strcmp (Fs_type, "devtmpfs") == 0         \
    || strcmp (Fs_type, "fusectl") == 0          \
    || strcmp (Fs_type, "mqueue") == 0           \
    || strcmp (Fs_type, "rpc_pipefs") == 0       \
-- 
1.7.6.4

Reply via email to