On Mon, Jan 05, 2015 at 04:06:15PM -0700, Eric Blake wrote: > On 12/15/2014 10:55 AM, Daniel P. Berrange wrote: > > On Mon, Dec 15, 2014 at 05:44:22PM +0000, Daniel P. Berrange wrote: > >> A previous commit attempted to workaround pollution in the > >> Mingw64 pthreads.h header file > >> > >> commit d5fec6c22f03c6a73d62260c9ce091c10c0a9cbd > >> Author: Eric Blake <ebl...@redhat.com> > >> Date: Wed Jan 22 20:39:45 2014 -0700 > >> > >> pthread: work around winpthread header pollution on mingw > >> > >> It activated its workaround based on existance of the strtok_r > >> wrapper in pthreads.h As luck would have it, latest Mingw64 > >> headers removed the strtok_r wrapper from pthreads.h, but left > >> all the others. So the gnulib workaround was not activated. > >> > >> Change the configure check to look for any of the broken > >> wrappers, instead of just strtok_r > > > > Actually, on closer inspection of winpthreads, I'm not convinced > > that we should include this patch in gnulib. > > > > For unknown reasons, Fedora 21 is currently shipping a point in > > time GIT snapshot of mingw64, instead of any official release. > > Still, the fact that a popular distro included the broken header at any > point in the past is an argument FOR including this patch. Even if a > modern F21 box doesn't have the issue, a developer that hasn't updated > to the latest release could be bitten by it.
FWIW, Fedora maintainer pushed the fix within a day of me filing a bug about this, so I don't think it is that important to fix in gnulib. If you want to include my patch though, its fine by me either way. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|