socket module and sc_prohibit_always_true_header_tests

[Tim Rühsen]

Hi,

at GNU Wget we are currently a bit puzzled about gnulib-tool's pro-tip

#if HAVE_SYS_SOCKET_H
# include <sys/socket.h>
#elif HAVE_WS2TCPIP_H
# include <ws2tcpip.h>
#endif

and 'make syntax-check' complaining about using HAVE_SYS_SOCKET_H:

maint.mk: do not test the above HAVE_<header>_H symbol(s);
  with the corresponding gnulib module, they are always true
make: *** [maint.mk:825: sc_prohibit_always_true_header_tests] Fehler 1

So far we dealt with it by disabling
sc_prohibit_always_true_header_tests in cfg.mk, but it feels wrong and
we want to use that check general.

Other project suffer from this as well, e.g. GnuTLS
(https://gitlab.com/gnutls/gnutls/commit/a75d97033c839b0a764b50280b88b8fc6e4baa9f).

What is your advise ?

Regards, Tim

signature.asc
Description: OpenPGP digital signature