Hi Bruno, Am Sa., 10. Okt. 2020 um 16:06 Uhr schrieb Bruno Haible <br...@clisp.org>: > > Hi Marc, > > > please see the attached patch for the new module. > > Very nice. Looks all good, except for some nit-picking in the comments:
Thanks. > > > + Introspection: ELEMENT *base = stack_base (&stack); > > I would add a comment here: > Where ELEMENT is the type to which GL_STACK_ELEMENT was defined when > this file was included. > (It would be tempting to write > GL_STACK_ELEMENT *base = stack_base (&stack); > but GL_STACK_ELEMENT is no longer defined after the file was included...) I will add this comment. > Other than that, please feel free to commit and push this. Thanks!! I will do this as soon as I have been approved by Paul. (Do I have to do something about the ChangeLog entry or will it be auto-generated from my Git commit message?) Marc