On 2024-01-27 13:06, Bruno Haible wrote:
${source_extra-"$source_extra"}
does word-splitting and globbing expansion of "$source_extra"
Sorry, that was a thinko. I installed the attached to fix that.
On 2024-01-27 15:36, Patrice Dumas wrote:
In my testings, I get an error.
This should be fixed by the attached patch.
Also the && at the end of the line seems strange to me. Isn't there a \
missing to protect the end of line?
It's OK. The shell treats '&&' like many other symbols, including '&',
'|', '||', ';', and ';;'. Newlines are allowed after these symbols. You
can also use backslash-newline (just as you can use backslash-newline in
lots of other places) but it's not necessary.From 5dc1eceb99681459af2fcfa09df2b966792de657 Mon Sep 17 00:00:00 2001
From: Paul Eggert <egg...@cs.ucla.edu>
Date: Sat, 27 Jan 2024 16:13:50 -0800
Subject: [PATCH] Fix typo in previous patch
* build-aux/gendocs.sh: Fix quoting typo.
Problem reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2024-01/msg00085.html
---
build-aux/gendocs.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/build-aux/gendocs.sh b/build-aux/gendocs.sh
index 9b601010a1..bdf105e02b 100755
--- a/build-aux/gendocs.sh
+++ b/build-aux/gendocs.sh
@@ -2,7 +2,7 @@
# gendocs.sh -- generate a GNU manual in many formats. This script is
# mentioned in maintain.texi. See the help message below for usage details.
-scriptversion=2024-01-27.12
+scriptversion=2024-01-27.16
# Copyright 2003-2024 Free Software Foundation, Inc.
#
@@ -430,7 +430,7 @@ d=`dirname $srcfile`
done
tar -czhf "$abs_outdir/$PACKAGE.texi.tar.gz" \
- -- $pats ${source_extra-"$source_extra"} &&
+ -- $pats ${source_extra+"$source_extra"} &&
ls -l "$abs_outdir/$PACKAGE.texi.tar.gz"
) || exit
texi_tgz_size=`calcsize "$outdir/$PACKAGE.texi.tar.gz"`
--
2.40.1
