Simon Josefsson wrote:
> I don't mind changing any ctime calls to strftime
> in code I come across, however I worry about not noticing these.  I
> didn't see anything in your patch that would warn about usage of ctime?

A regular expression search can find such uses as well.

All of ctime, ctime_r, asctime, asctime_r are affected in the same way.[1][2]

Using https://codesearch.debian.net with the search string
  \b(as)?ctime(_r)?\b *[(] filetype:c
(in regex mode) lists occurrences in more than 1300 packages (!).

For example, in specific GNU packages:
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Abinutils&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Acpio&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Aemacs&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Afindutils&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Agawk&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Acpp+package%3Agroff&literal=0
https://codesearch.debian.net/search?q=%5Cb%28as%29%3Fctime%28_r%29%3F%5Cb+*%5B%28%5D+filetype%3Ac+package%3Ainetutils&literal=0

Bruno

[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/ctime.html
[2] https://pubs.opengroup.org/onlinepubs/9699919799/functions/asctime.html




Reply via email to