Collin Funk wrote:
> Here is two patches. The first fixes on item in gnulib-tool.py.TODO.

Thanks. Applied. Since I misunderstood the 'gentests' description when I read
it, I'm clarifying it.

> I thought I remembered seeing a good test case for this on the mailing
> list but the archives seem to be down at the moment.

Yep, lists.gnu.org still does not answer.
https://hostux.social/@fsfstatus has no info. 
https://www.gnu.org/server/irc-rules.en.html mentions the IRC channel #savannah.

> The second fixes this diff in gnulib-cache.m4 I found when testing:
> 
> diff --git a/test-python/m4/gnulib-cache.m4 b/test-shell/m4/gnulib-cache.m4
> index 6afe7d8d1c..91f3e48123 100644
> --- a/test-python/m4/gnulib-cache.m4
> +++ b/test-shell/m4/gnulib-cache.m4
> @@ -27,7 +27,7 @@
>  
>  
>  # Specification in the form of a command-line invocation:
> -#   # gnulib-tool --import \
> +# gnulib-tool --import \
>  #  --lib=libgnu \
>  #  --source-base=lib \
>  #  --m4-base=m4 \
> 
> The actioncmd already handles the comment '#' so we don't need another
> when outputting in gnulib_cache.

Applied as well; thanks.


2024-03-06  Bruno Haible  <br...@clisp.org>

        gnulib-tool.py: Tweak comment.
        * pygnulib/GLMakefileTable.py (GLMakefileTable.parent): Tweak 'gentests'
        description.

diff --git a/pygnulib/GLMakefileTable.py b/pygnulib/GLMakefileTable.py
index d1e6178880..35f32685b5 100644
--- a/pygnulib/GLMakefileTable.py
+++ b/pygnulib/GLMakefileTable.py
@@ -87,7 +87,7 @@ class GLMakefileTable(object):
         which contains or will contain Makefile.am file.
         GLConfig: sourcebase, m4base, testsbase, incl_test_categories,
         excl_test_categories, makefile_name.
-        gentests is a bool that is True if files are placed in $testsbase.'''
+        gentests is a bool that is True if any files are to be placed in 
$testsbase.'''
         if type(gentests) is not bool:
             raise TypeError('gentests must be a bool, not %s' % 
(type(gentests).__name__))
         m4base = self.config['m4base']




Reply via email to