Hello, I was about to start working on gnulib-tool.py a bit more today and remembered seeing something I wanted to ask about. When creating a testdir that uses system headers, you see the following lines when diff'ing 'gltests/Makefile.am' from each implementation:
# Use $(gl_V_at) instead of $(AM_V_GEN) or $(AM_V_at) on a line that -gl_V_at = $(AM_V_GEN) +# is its recipe's first line if and only if @NMD@ lines are absent. +@NMD@gl_V_at = $(AM_V_at) +@!NMD@gl_V_at = $(AM_V_GEN) I have not implemented it yet in gnulib-tool.py so the snippet is just copy and pasted from the module. The part I wanted to ask about was the second line of the comment which is removed by gnulib-tool. Should the sed invocations [1] be changed to only replace lines if they start with @NMD@ instead of all lines that contain @NMD@? I think that it would be nice to preserve the comment just in case someone ever has to look at the generated Makefile for whatever reason. It seems that the module files were written to handle this restriction so it hopefully wouldn't require changes outside of gnulib-tool. [1] https://git.savannah.gnu.org/cgit/gnulib.git/tree/gnulib-tool#n3776 [2] https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=83a0d5891db50c00e283e70df694b6003b1f485d Collin
